Summary: | [css-values-4] Support font-relative lh and rlh unit | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gérard Talbot <browserbugs2> | ||||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, koivisto, kondapallykalyan, kyle.bavender, macpherson, menard, mifenton, pdr, philipj, sergio, simon.fraser, twilco.o, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar, W3CTest, WebExposed, WPTImpact | ||||||||||||||
Version: | Safari Technology Preview | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
URL: | http://w3c-test.org/css/css-values/lh-rlh-on-root-001.html | ||||||||||||||||
Bug Depends on: | 211351 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Gérard Talbot
2019-02-28 12:17:42 PST
Hi! Looks like there is a duplicate of this -- https://bugs.webkit.org/show_bug.cgi?id=204277. *** Bug 204277 has been marked as a duplicate of this bug. *** Created attachment 395461 [details]
Patch
Hello! This is my first patch -- hope I've done everything correct. I look forward to your review. Created attachment 395462 [details]
Patch
Created attachment 395473 [details]
Patch
Created attachment 395479 [details]
Patch
Created attachment 395487 [details]
Patch
Sorry for the churn — should be all set for review now. Comment on attachment 395487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395487&action=review Looks good! > Source/WebCore/css/CSSToLengthConversionData.h:44 > +enum class ComputingProperty { > + FontSize, > + LineHeight, > + OtherOrUnknown > +}; An alternative approach would be to use Optional<CSSPropertyID> instead of this (passing CSSPropertyFontSize/CSSPropertyLineHeight where appropriate). If you keep the enum it should move to CSSToLengthConversionData namespace. PropertyToCompute or just PropertyType might read better. > Source/WebCore/css/CSSToLengthConversionData.h:48 > + CSSToLengthConversionData(const RenderStyle* style, const RenderStyle* rootStyle, const RenderStyle* parentStyle, const RenderView* renderView, float zoom, ComputingProperty computingProperty = ComputingProperty::OtherOrUnknown) 'computingProperty' is an awkward name for variables and fields too Created attachment 395653 [details]
Patch
Thanks for the suggestions, I've applied them in this new patch. Thanks for the patch! Committed r259703: <https://trac.webkit.org/changeset/259703> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395653 [details]. This was moved behind an off-by-default flag: https://bugs.webkit.org/show_bug.cgi?id=211356 |