Bug 195136

Summary:

Web Inspector: Canvas: change tests to not print out dataURLs

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2019-02-27 17:26:08 PST

There's no reason to print the exact dataURL, especially when the test isn't actually testing the content (e.g. the recording tests care more about the fact that content was sent, not necessarily what that content was).

Comment 1 Devin Rousso 2019-02-27 17:26:21 PST

<rdar://problem/48248697>

Comment 2 Devin Rousso 2019-02-27 17:27:31 PST

Created attachment 363165 [details]
Patch

Comment 3 Matt Baker 2019-02-27 17:43:15 PST

Comment on attachment 363165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363165&action=review

r=me, nice change.

> LayoutTests/inspector/canvas/requestContent-2d.html:28
> +            .then(({content}) => InspectorTest.expectGreaterThan(content.length, "data:image/png;base64,".length, "The content should not be empty."))

I'd drop the article from all of these: "Content should not be empty."

> LayoutTests/inspector/canvas/setShaderProgramHighlighted-expected.txt:12
> +PASS: Unhighlighting a shader program should draw differently.

Can this just be "Unhighlighting a shader program should change the content", or does the distinction matter?

Comment 4 Devin Rousso 2019-02-28 09:55:16 PST

Created attachment 363232 [details]
Patch

Comment 5 WebKit Commit Bot 2019-02-28 14:01:29 PST

Comment on attachment 363232 [details]
Patch

Clearing flags on attachment: 363232

Committed r242225: <https://trac.webkit.org/changeset/242225>

Comment 6 WebKit Commit Bot 2019-02-28 14:01:31 PST

All reviewed patches have been landed.  Closing bug.