Bug 195136

Summary: Web Inspector: Canvas: change tests to not print out dataURLs
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-02-27 17:26:08 PST
There's no reason to print the exact dataURL, especially when the test isn't actually testing the content (e.g. the recording tests care more about the fact that content was sent, not necessarily what that content was).
Attachments
Patch (47.43 KB, patch)
2019-02-27 17:27 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (47.40 KB, patch)
2019-02-28 09:55 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-02-27 17:26:21 PST
<rdar://problem/48248697>
Devin Rousso
Comment 2 2019-02-27 17:27:31 PST
Created attachment 363165 [details] Patch
Matt Baker
Comment 3 2019-02-27 17:43:15 PST
Comment on attachment 363165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363165&action=review r=me, nice change. > LayoutTests/inspector/canvas/requestContent-2d.html:28 > + .then(({content}) => InspectorTest.expectGreaterThan(content.length, "data:image/png;base64,".length, "The content should not be empty.")) I'd drop the article from all of these: "Content should not be empty." > LayoutTests/inspector/canvas/setShaderProgramHighlighted-expected.txt:12 > +PASS: Unhighlighting a shader program should draw differently. Can this just be "Unhighlighting a shader program should change the content", or does the distinction matter?
Devin Rousso
Comment 4 2019-02-28 09:55:16 PST
Created attachment 363232 [details] Patch
WebKit Commit Bot
Comment 5 2019-02-28 14:01:29 PST
Comment on attachment 363232 [details] Patch Clearing flags on attachment: 363232 Committed r242225: <https://trac.webkit.org/changeset/242225>
WebKit Commit Bot
Comment 6 2019-02-28 14:01:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.