| Summary: | Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, achristensen, ap, beidson, cdumez, commit-queue, ews-watchlist, ggaren, koivisto, lforschler, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=194105 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2019-02-27 10:41:42 PST
This test was added in https://trac.webkit.org/changeset/240818/webkit Created attachment 363226 [details]
Patch
Attachment 363226 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363226&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2788 > + } while (clientWidth != expectedClientWidth); Having a maximum number of tries would help us debug any future problems with this, turning a timeout into an eventual failure. Right now the maximum is effectively 1, and this patch makes it infinite. Somewhere between the two ought to be good. Created attachment 363236 [details]
Patch
Attachment 363236 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363236 [details] Patch Clearing flags on attachment: 363236 Committed r242208: <https://trac.webkit.org/changeset/242208> All reviewed patches have been landed. Closing bug. |