Bug 195107

Summary: Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, beidson, cdumez, commit-queue, ews-watchlist, ggaren, koivisto, lforschler, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194105
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2019-02-27 10:41:42 PST
TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap seems flaky. In http://ews-build.webkit-uat.org/#/builders/19/builds/1291, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.
Attachments
Patch (4.61 KB, patch)
2019-02-28 09:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2019-02-28 10:24 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-02-28 05:09:08 PST
This test was added in https://trac.webkit.org/changeset/240818/webkit
Chris Dumez
Comment 2 2019-02-28 09:02:41 PST
Created attachment 363226 [details] Patch
EWS Watchlist
Comment 3 2019-02-28 09:05:08 PST
Attachment 363226 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 4 2019-02-28 10:19:37 PST
Comment on attachment 363226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363226&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2788 > + } while (clientWidth != expectedClientWidth); Having a maximum number of tries would help us debug any future problems with this, turning a timeout into an eventual failure. Right now the maximum is effectively 1, and this patch makes it infinite. Somewhere between the two ought to be good.
Chris Dumez
Comment 5 2019-02-28 10:24:39 PST
Created attachment 363236 [details] Patch
EWS Watchlist
Comment 6 2019-02-28 10:26:50 PST
Attachment 363236 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2019-02-28 10:52:01 PST
Comment on attachment 363236 [details] Patch Clearing flags on attachment: 363236 Committed r242208: <https://trac.webkit.org/changeset/242208>
WebKit Commit Bot
Comment 8 2019-02-28 10:52:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-02-28 11:12:25 PST
<rdar://problem/48481175>
Note You need to log in before you can comment on or make changes to this bug.