Bug 195105 – Web Inspector: Sources: breakpoints should be disabled when an audit is running

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

This hadn't yet been created when the first Sources patch was uploaded.

[Radar WebKit Bug Importer]

<rdar://problem/48441373>

[Devin Rousso]

Created attachment 363105 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 363105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663
> +            let stopAuditButton = document.createElement("button");

In the Debugger tab this is a "a" not a "button". Why the change?

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665
> +            stopAuditButton.addEventListener("click", () => {

Nit: Don't you prefer putting `event` in the param?

[Devin Rousso]

Comment on attachment 363105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review

>> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663
>> +            let stopAuditButton = document.createElement("button");
> 
> In the Debugger tab this is a "a" not a "button". Why the change?

I prefer <button> over <a> in most cases.  Using an <a> didn't feel as "obvious"/"actionable" as a <button>.  The rest of the Sources navigation sidebar also follows this pattern (as well as the general "Clear Filters").

>> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665
>> +            stopAuditButton.addEventListener("click", () => {
> 
> Nit: Don't you prefer putting `event` in the param?

Oops :P

[Devin Rousso]

Created attachment 363425 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 363425 [details]
Patch

Clearing flags on attachment: 363425

Committed r242315: <https://trac.webkit.org/changeset/242315>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.