Summary: | Web Inspector: Sources: breakpoints should be disabled when an audit is running | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2019-02-27 10:13:05 PST
Created attachment 363105 [details]
Patch
Comment on attachment 363105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663 > + let stopAuditButton = document.createElement("button"); In the Debugger tab this is a "a" not a "button". Why the change? > Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665 > + stopAuditButton.addEventListener("click", () => { Nit: Don't you prefer putting `event` in the param? Comment on attachment 363105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review >> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663 >> + let stopAuditButton = document.createElement("button"); > > In the Debugger tab this is a "a" not a "button". Why the change? I prefer <button> over <a> in most cases. Using an <a> didn't feel as "obvious"/"actionable" as a <button>. The rest of the Sources navigation sidebar also follows this pattern (as well as the general "Clear Filters"). >> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665 >> + stopAuditButton.addEventListener("click", () => { > > Nit: Don't you prefer putting `event` in the param? Oops :P Created attachment 363425 [details]
Patch
Comment on attachment 363425 [details] Patch Clearing flags on attachment: 363425 Committed r242315: <https://trac.webkit.org/changeset/242315> All reviewed patches have been landed. Closing bug. |