Bug 195101

Summary: Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2019-02-27 09:34:28 PST 
Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled.
Comment 1 Chris Dumez 2019-02-27 09:34:42 PST 
<rdar://problem/48423023>
Comment 2 Chris Dumez 2019-02-27 09:55:18 PST 
Created attachment 363097 [details]
Patch
Comment 3 Geoffrey Garen 2019-02-27 10:30:15 PST 
Comment on attachment 363097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review

r=me with one change

> Source/WebCore/page/DOMWindow.cpp:1894
> +    if (!isSameSecurityOriginAsMainFrame() || !isSecureContext())
> +        return;

Can you add a test for needsSiteSpecificQuirks here, so that website developers can disable the quirk when testing a fix?
Comment 4 Chris Dumez 2019-02-27 10:31:06 PST 
Comment on attachment 363097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review

> Source/WebCore/ChangeLog:13
> +        Unfortunately, document()->settings().needsSiteSpecificQuirks() is false on iOS so I could not

See this line in the change log.
Comment 5 Geoffrey Garen 2019-02-27 10:34:23 PST 
Sad face.
Comment 6 WebKit Commit Bot 2019-02-27 11:03:27 PST 
Comment on attachment 363097 [details]
Patch

Clearing flags on attachment: 363097

Committed r242138: <https://trac.webkit.org/changeset/242138>
Comment 7 WebKit Commit Bot 2019-02-27 11:03:29 PST 
All reviewed patches have been landed.  Closing bug.