Bug 195091

Summary: [ContentChangeObserver] Move _WKObservingContentChanges from global to ContentChangeObserver class
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2019-02-26 21:19:42 PST 
ssia
Comment 1 zalan 2019-02-26 21:34:20 PST 
Created attachment 363066 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-02-26 21:34:45 PST 
<rdar://problem/48427271>
Comment 3 zalan 2019-02-26 21:36:36 PST 
Created attachment 363067 [details]
Patch
Comment 4 zalan 2019-02-27 16:24:05 PST 
Created attachment 363153 [details]
Patch
Comment 5 EWS Watchlist 2019-02-27 16:26:12 PST 
Attachment 363153 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:37:  _WKContentChange is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2019-02-27 16:58:19 PST 
Comment on attachment 363153 [details]
Patch

Clearing flags on attachment: 363153

Committed r242184: <https://trac.webkit.org/changeset/242184>
Comment 7 WebKit Commit Bot 2019-02-27 16:58:21 PST 
All reviewed patches have been landed.  Closing bug.