RESOLVED FIXED 195091
[ContentChangeObserver] Move _WKObservingContentChanges from global to ContentChangeObserver class 
https://bugs.webkit.org/show_bug.cgi?id=195091
Summary [ContentChangeObserver] Move _WKObservingContentChanges from global to Conten...
alan
Reported 2019-02-26 21:19:42 PST
ssia
Attachments
Patch (4.53 KB, patch)
2019-02-26 21:34 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2019-02-26 21:36 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2019-02-27 16:24 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-02-26 21:34:20 PST
Created attachment 363066 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-26 21:34:45 PST
<rdar://problem/48427271>
alan
Comment 3 2019-02-26 21:36:36 PST
Created attachment 363067 [details] Patch
alan
Comment 4 2019-02-27 16:24:05 PST
Created attachment 363153 [details] Patch
EWS Watchlist
Comment 5 2019-02-27 16:26:12 PST
Attachment 363153 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:37: _WKContentChange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2019-02-27 16:58:19 PST
Comment on attachment 363153 [details] Patch Clearing flags on attachment: 363153 Committed r242184: <https://trac.webkit.org/changeset/242184>
WebKit Commit Bot
Comment 7 2019-02-27 16:58:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.