Bug 195091 - [ContentChangeObserver] Move _WKObservingContentChanges from global to ContentChangeObserver class
Summary: [ContentChangeObserver] Move _WKObservingContentChanges from global to Conten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-26 21:19 PST by zalan
Modified: 2019-02-27 16:58 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.53 KB, patch)
2019-02-26 21:34 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2019-02-26 21:36 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (5.78 KB, patch)
2019-02-27 16:24 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-26 21:19:42 PST
ssia
Comment 1 zalan 2019-02-26 21:34:20 PST
Created attachment 363066 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-02-26 21:34:45 PST
<rdar://problem/48427271>
Comment 3 zalan 2019-02-26 21:36:36 PST
Created attachment 363067 [details]
Patch
Comment 4 zalan 2019-02-27 16:24:05 PST
Created attachment 363153 [details]
Patch
Comment 5 EWS Watchlist 2019-02-27 16:26:12 PST
Attachment 363153 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKContentObservation.cpp:37:  _WKContentChange is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2019-02-27 16:58:19 PST
Comment on attachment 363153 [details]
Patch

Clearing flags on attachment: 363153

Committed r242184: <https://trac.webkit.org/changeset/242184>
Comment 7 WebKit Commit Bot 2019-02-27 16:58:21 PST
All reviewed patches have been landed.  Closing bug.