Bug 195087

Summary: [ContentChangeObserver] Move style recalc handling from global to ContentChangeObserver class
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

zalan
Reported 2019-02-26 19:14:37 PST
ssia
Attachments
Patch (6.32 KB, patch)
2019-02-26 19:19 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.04 KB, patch)
2019-02-27 14:56 PST, zalan 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-02-26 19:19:16 PST
Created attachment 363059 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-26 19:19:42 PST
<rdar://problem/48425308>
Tim Horton
Comment 3 2019-02-26 23:17:00 PST
Comment on attachment 363059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363059&action=review red patch > Source/WebCore/page/ios/ContentChangeObserver.mm:185 > + m_observingStyleRecalScheduling = true; "Recal"? > Source/WebCore/page/ios/ContentChangeObserver.mm:190 > + m_observingStyleRecalScheduling = false; "Recal"? > Source/WebCore/page/ios/ContentChangeObserver.mm:195 > + return m_observingStyleRecalScheduling; "Recal"?
zalan
Comment 4 2019-02-27 09:05:46 PST
(In reply to Tim Horton from comment #3) > Comment on attachment 363059 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=363059&action=review > > red patch Happens when you make patches faster than you land them. > > > Source/WebCore/page/ios/ContentChangeObserver.mm:185 > > + m_observingStyleRecalScheduling = true; > > "Recal"? > > > Source/WebCore/page/ios/ContentChangeObserver.mm:190 > > + m_observingStyleRecalScheduling = false; > > "Recal"? > > > Source/WebCore/page/ios/ContentChangeObserver.mm:195 > > + return m_observingStyleRecalScheduling; > > "Recal"? Yeah, it's actually a thing -> bool inStyleRecalc(); void scheduleStyleRecalc(); void unscheduleStyleRecalc(); bool hasPendingStyleRecalc() const; void startTrackingStyleRecalcs(); (!even plural) unsigned styleRecalcCount() const; ...
Tim Horton
Comment 5 2019-02-27 10:22:23 PST
(In reply to zalan from comment #4) > (In reply to Tim Horton from comment #3) > > Comment on attachment 363059 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=363059&action=review > > > > red patch > Happens when you make patches faster than you land them. > > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:185 > > > + m_observingStyleRecalScheduling = true; > > > > "Recal"? > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:190 > > > + m_observingStyleRecalScheduling = false; > > > > "Recal"? > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:195 > > > + return m_observingStyleRecalScheduling; > > > > "Recal"? > Yeah, it's actually a thing -> > > bool inStyleRecalc(); > void scheduleStyleRecalc(); > void unscheduleStyleRecalc(); > bool hasPendingStyleRecalc() const; > void startTrackingStyleRecalcs(); (!even plural) > unsigned styleRecalcCount() const; > ... Those are recalc, not recal!
zalan
Comment 6 2019-02-27 10:23:02 PST
(In reply to Tim Horton from comment #5) > (In reply to zalan from comment #4) > > (In reply to Tim Horton from comment #3) > > > Comment on attachment 363059 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=363059&action=review > > > > > > red patch > > Happens when you make patches faster than you land them. > > > > > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:185 > > > > + m_observingStyleRecalScheduling = true; > > > > > > "Recal"? > > > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:190 > > > > + m_observingStyleRecalScheduling = false; > > > > > > "Recal"? > > > > > > > Source/WebCore/page/ios/ContentChangeObserver.mm:195 > > > > + return m_observingStyleRecalScheduling; > > > > > > "Recal"? > > Yeah, it's actually a thing -> > > > > bool inStyleRecalc(); > > void scheduleStyleRecalc(); > > void unscheduleStyleRecalc(); > > bool hasPendingStyleRecalc() const; > > void startTrackingStyleRecalcs(); (!even plural) > > unsigned styleRecalcCount() const; > > ... > Those are recalc, not recal! lol
zalan
Comment 7 2019-02-27 14:56:28 PST
Created attachment 363136 [details] Patch
Simon Fraser (smfr)
Comment 8 2019-02-27 15:15:52 PST
Comment on attachment 363136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363136&action=review > Source/WebCore/ChangeLog:8 > + Add m_observingNextStyleRecalc/m_observingStyleRecalScheduling to ContentChangeObserver and move the related code over from WK functions. m_observingStyleRecalcScheduling
zalan
Comment 9 2019-02-27 15:29:11 PST
Committed r242167: <https://trac.webkit.org/changeset/242167>
Note You need to log in before you can comment on or make changes to this bug.