Bug 195070

Summary:

[ContentChangeObserver] Move DOM timer handling from global to ContentChangeObserver class

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none

alan

Reported 2019-02-26 15:17:05 PST

don't be global.

Attachments
Patch (7.43 KB, patch) 2019-02-26 15:25 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.68 MB, application/zip) 2019-02-26 20:09 PST, EWS Watchlist	no flags	Details
Patch (8.07 KB, patch) 2019-02-27 14:20 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-02-26 15:22:01 PST

<rdar://problem/48417650>

alan

Comment 2 2019-02-26 15:25:13 PST

Created attachment 363028 [details] Patch

Tim Horton

Comment 3 2019-02-26 15:36:52 PST

Comment on attachment 363028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363028&action=review > Source/WebCore/page/ios/ContentChangeObserver.h:98 > + extra space!

EWS Watchlist

Comment 4 2019-02-26 20:09:54 PST

Comment on attachment 363028 [details] Patch Attachment 363028 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11297685 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

EWS Watchlist

Comment 5 2019-02-26 20:09:55 PST

Created attachment 363061 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

alan

Comment 6 2019-02-27 14:20:56 PST

Created attachment 363131 [details] Patch

WebKit Commit Bot

Comment 7 2019-02-27 15:20:49 PST

Comment on attachment 363131 [details] Patch Clearing flags on attachment: 363131 Committed r242166: <https://trac.webkit.org/changeset/242166>

WebKit Commit Bot

Comment 8 2019-02-27 15:20:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.