Bug 195070 - [ContentChangeObserver] Move DOM timer handling from global to ContentChangeObserver class
Summary: [ContentChangeObserver] Move DOM timer handling from global to ContentChangeO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-26 15:17 PST by zalan
Modified: 2019-02-27 15:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.43 KB, patch)
2019-02-26 15:25 PST, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.68 MB, application/zip)
2019-02-26 20:09 PST, EWS Watchlist 		no flags Details
Patch (8.07 KB, patch)
2019-02-27 14:20 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-26 15:17:05 PST 
don't be global.
Comment 1 Radar WebKit Bug Importer 2019-02-26 15:22:01 PST 
<rdar://problem/48417650>
Comment 2 zalan 2019-02-26 15:25:13 PST 
Created attachment 363028 [details]
Patch
Comment 3 Tim Horton 2019-02-26 15:36:52 PST 
Comment on attachment 363028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363028&action=review

> Source/WebCore/page/ios/ContentChangeObserver.h:98
> +

extra space!
Comment 4 EWS Watchlist 2019-02-26 20:09:54 PST 
Comment on attachment 363028 [details]
Patch

Attachment 363028 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11297685

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
Comment 5 EWS Watchlist 2019-02-26 20:09:55 PST 
Created attachment 363061 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 zalan 2019-02-27 14:20:56 PST 
Created attachment 363131 [details]
Patch
Comment 7 WebKit Commit Bot 2019-02-27 15:20:49 PST 
Comment on attachment 363131 [details]
Patch

Clearing flags on attachment: 363131

Committed r242166: <https://trac.webkit.org/changeset/242166>
Comment 8 WebKit Commit Bot 2019-02-27 15:20:51 PST 
All reviewed patches have been landed.  Closing bug.