Bug 195060

Summary: Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-02-26 11:42:08 PST
# STEPS TO REPRODUCE: 1. inspect any page 2. go to the Canvas tab 3. delete all text inside the auto-capture frame count <input> (make sure the checkbox is unchecked) 4. click the checkbox => the <input> is empty and has the placeholder "null"
Attachments
Patch (3.38 KB, patch)
2019-02-26 11:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-02-26 11:47:16 PST
Created attachment 362999 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-26 11:47:34 PST
<rdar://problem/48408669>
Matt Baker
Comment 3 2019-02-28 12:41:17 PST
Comment on attachment 362999 [details] Patch r=me, nice refactor. It makes much more sense to check this._recordingAutoCaptureFrameCountInputElementValue separately from setting the frame count and updating the label.
WebKit Commit Bot
Comment 4 2019-02-28 13:07:05 PST
Comment on attachment 362999 [details] Patch Clearing flags on attachment: 362999 Committed r242217: <https://trac.webkit.org/changeset/242217>
WebKit Commit Bot
Comment 5 2019-02-28 13:07:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.