|Summary:||[ews-build] Buildbot should include builder_display_name in the build events|
|Product:||WebKit||Reporter:||Aakash Jain <aakash_jain>|
|Component:||Tools / Tests||Assignee:||Aakash Jain <aakash_jain>|
|Severity:||Normal||CC:||aakash_jain, ap, commit-queue, dean_johnson, dewei_zhu, ews-watchlist, jbedard, kocsen_chung, lforschler, slewis, webkit-bug-importer|
Description Aakash Jain 2019-02-26 06:41:57 PST
After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_display_name. So, buildbot should include builder_display_name in the build event data (e.g.: build-start/end events) it send to ews-app.
Comment 2 EWS Watchlist 2019-02-26 06:50:43 PST Comment hidden (obsolete)
Attachment 362981 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/events.py:112: [Events.buildStarted] Instance of 'Events' has no 'master' member [pylint/E1101]  ERROR: Tools/BuildSlaveSupport/ews-build/events.py:139: [Events.buildFinished] Instance of 'Events' has no 'master' member [pylint/E1101]  Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jonathan Bedard 2019-02-26 10:13:25 PST
This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them?
Comment 4 Aakash Jain 2019-02-26 10:38:09 PST
> any reason to separate them? I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch.
Comment 5 WebKit Commit Bot 2019-02-27 17:47:09 PST
Comment on attachment 362981 [details] Proposed patch Clearing flags on attachment: 362981 Committed r242185: <https://trac.webkit.org/changeset/242185>
Comment 6 WebKit Commit Bot 2019-02-27 17:47:10 PST
All reviewed patches have been landed. Closing bug.