Bug 194995

Summary: [iOS] Adjust initial scale zooming heuristics when changing view scale
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, thorton, webkit-bug-importer, yongjun_zhang
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2019-02-24 16:54:31 PST
Currently, we only zoom to the new initial scale iff we're exactly at initial scale before changing the view scale. This was done so that if a user zoomed in really far and then increased the view scale, we wouldn't end up zooming out as a result. Per conversation with Tim and Yongjun, we should consider changing the heuristics here, such that: • If the view scale is increasing and the new initial scale is greater than the current scale, zoom to initial scale. • Likewise, if the view scale is decreasing and the new initial scale is less than the current scale, zoom to initial scale.
Attachments
Patch (9.65 KB, patch)
2019-02-24 17:16 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-02-24 17:16:46 PST
Created attachment 362869 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-25 16:19:56 PST
Comment on attachment 362869 [details] Patch Clearing flags on attachment: 362869 Committed r242059: <https://trac.webkit.org/changeset/242059>
WebKit Commit Bot
Comment 3 2019-02-25 16:19:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-02-25 16:20:54 PST
<rdar://problem/48382246>
Note You need to log in before you can comment on or make changes to this bug.