Bug 194987

Summary: [ContentChangeObserver] Move observing logic from DOMTimer to ContentChangeObserver
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, thorton, tsavell, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2019-02-23 21:36:36 PST
That's where the logic belongs.
Comment 1 Radar WebKit Bug Importer 2019-02-23 21:37:05 PST
<rdar://problem/48342910>
Comment 2 zalan 2019-02-23 21:41:05 PST
Created attachment 362852 [details]
Patch
Comment 3 zalan 2019-02-25 14:01:56 PST
Created attachment 362926 [details]
Patch
Comment 4 zalan 2019-02-25 14:15:40 PST
Created attachment 362927 [details]
Patch
Comment 5 zalan 2019-02-25 15:06:33 PST
Created attachment 362931 [details]
Patch
Comment 6 zalan 2019-02-25 15:11:25 PST
Committed r242058: <https://trac.webkit.org/changeset/242058>
Comment 7 Truitt Savell 2019-02-26 15:48:13 PST
Looks like the changes in https://trac.webkit.org/changeset/242058/webkit

caused fast/dom/Window/timer-null-script-execution-context.html to crash constantly on iOS.

History:
fast/dom/Window/timer-null-script-execution-context.html

reproduced with command:
run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html --ios-simulator

test crashes on r242058 but not on r242057.

The test is crashing with no crash log available.
Comment 8 zalan 2019-02-26 15:52:47 PST
(In reply to Truitt Savell from comment #7)
> Looks like the changes in https://trac.webkit.org/changeset/242058/webkit
> 
> caused fast/dom/Window/timer-null-script-execution-context.html to crash
> constantly on iOS.
> 
> History:
> fast/dom/Window/timer-null-script-execution-context.html
> 
> reproduced with command:
> run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html
> --ios-simulator
> 
> test crashes on r242058 but not on r242057.
> 
> The test is crashing with no crash log available.
Thanks. Looking into it.