Bug 194969

Summary: Give DrawingAreas their own identifiers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, simon.fraser, sroberts, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Follow-up fix for API tests none

Chris Dumez
Reported 2019-02-22 16:55:33 PST
Give DrawingAreas their own identifiers instead of using the pageID. It will make the IPC more robust now that a WebPageProxy can have several drawing areas with PSON.
Attachments
Patch (40.90 KB, patch)
2019-02-22 16:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Follow-up fix for API tests (4.42 KB, patch)
2019-02-23 17:47 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-02-22 16:56:00 PST
<rdar://problem/48154508>
Chris Dumez
Comment 2 2019-02-22 16:59:41 PST
Created attachment 362794 [details] Patch
Chris Dumez
Comment 3 2019-02-22 17:00:27 PST
Needs more testing, especially on macOS. May need a little more work to build everywhere.
Geoffrey Garen
Comment 4 2019-02-22 20:42:36 PST
Comment on attachment 362794 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-02-22 21:30:25 PST
Comment on attachment 362794 [details] Patch Clearing flags on attachment: 362794 Committed r241988: <https://trac.webkit.org/changeset/241988>
WebKit Commit Bot
Comment 6 2019-02-22 21:30:27 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2019-02-23 17:47:07 PST
Reopening to attach new patch.
Chris Dumez
Comment 8 2019-02-23 17:47:09 PST
Created attachment 362842 [details] Follow-up fix for API tests
WebKit Commit Bot
Comment 9 2019-02-23 19:03:15 PST
Comment on attachment 362842 [details] Follow-up fix for API tests Clearing flags on attachment: 362842 Committed r242010: <https://trac.webkit.org/changeset/242010>
WebKit Commit Bot
Comment 10 2019-02-23 19:03:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.