Bug 194962

Summary: Add an exception check and some assertions in StringPrototype.cpp.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ysuzuki: review+
patch for landing w/ build fixes.
none
patch for landing.
none
patch for landing (uploaded to hopefully tickle the EWS bots into running).
none
patch for landing.
none
patch for landing: 6th time's the charm. none

Mark Lam
Reported 2019-02-22 15:54:25 PST
<rdar://problem/48013416>
Attachments
proposed patch. (13.34 KB, patch)
2019-02-22 16:01 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing w/ build fixes. (13.45 KB, patch)
2019-02-22 16:28 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing. (13.45 KB, patch)
2019-02-22 16:56 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing (uploaded to hopefully tickle the EWS bots into running). (13.45 KB, patch)
2019-02-22 17:18 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing. (13.64 KB, patch)
2019-02-22 17:42 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing: 6th time's the charm. (13.66 KB, patch)
2019-02-22 17:52 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-02-22 16:01:36 PST
Created attachment 362775 [details] proposed patch.
Yusuke Suzuki
Comment 2 2019-02-22 16:06:53 PST
Comment on attachment 362775 [details] proposed patch. r=me
Saam Barati
Comment 3 2019-02-22 16:07:53 PST
Comment on attachment 362775 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=362775&action=review > Source/WTF/wtf/CheckedArithmetic.h:545 > +inline bool observesOverflows() { return true; } constexpr? I'd also name this "ovservesOverflow" > Source/WTF/wtf/CheckedArithmetic.h:548 > +inline bool observesOverflows<AssertNoOverflow>() { return !ASSERT_DISABLED; } constexpr?
Mark Lam
Comment 4 2019-02-22 16:27:16 PST
Thanks for the reviews. (In reply to Saam Barati from comment #3) > Comment on attachment 362775 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362775&action=review > > > Source/WTF/wtf/CheckedArithmetic.h:545 > > +inline bool observesOverflows() { return true; } > > constexpr? > > I'd also name this "ovservesOverflow" > > > Source/WTF/wtf/CheckedArithmetic.h:548 > > +inline bool observesOverflows<AssertNoOverflow>() { return !ASSERT_DISABLED; } > > constexpr? I'll apply these changes.
Mark Lam
Comment 5 2019-02-22 16:28:54 PST
Created attachment 362784 [details] patch for landing w/ build fixes. Let's see if the EWS likes this better.
Mark Lam
Comment 6 2019-02-22 16:56:18 PST
Created attachment 362790 [details] patch for landing. Let's try the EWS again with a different fix.
Mark Lam
Comment 7 2019-02-22 17:18:27 PST
Created attachment 362800 [details] patch for landing (uploaded to hopefully tickle the EWS bots into running).
Mark Lam
Comment 8 2019-02-22 17:42:38 PST
Created attachment 362805 [details] patch for landing. The issue does not repro on my local builds. So let's try another speculative build fix.
Mark Lam
Comment 9 2019-02-22 17:52:45 PST
Created attachment 362807 [details] patch for landing: 6th time's the charm.
Mark Lam
Comment 10 2019-02-23 10:16:19 PST
Landed in r241991: <http://trac.webkit.org/r241991>.
Note You need to log in before you can comment on or make changes to this bug.