Bug 194958

Summary:

Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Sihui Liu

Reported 2019-02-22 13:01:01 PST

ProcessPoolConfiguration::ProcessPoolConfiguration() uses WebsiteDataStore::defaultIndexedDBDatabaseDirectory(), but ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration(const WebKit::WebsiteDataStoreConfiguration&) always uses WebsiteDataStore::legacyDefaultIndexedDBDatabaseDirectory(). Therefore it's possible we operate on different directories when using WKWebsiteDataStore.

Attachments
Patch (10.13 KB, patch) 2019-02-22 13:21 PST, Sihui Liu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sihui Liu

Comment 1 2019-02-22 13:21:09 PST

Created attachment 362756 [details] Patch

Geoffrey Garen

Comment 2 2019-02-23 09:20:11 PST

Comment on attachment 362756 [details] Patch r=me

WebKit Commit Bot

Comment 3 2019-02-28 10:15:27 PST

Comment on attachment 362756 [details] Patch Clearing flags on attachment: 362756 Committed r242203: <https://trac.webkit.org/changeset/242203>

WebKit Commit Bot

Comment 4 2019-02-28 10:15:29 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-02-28 10:17:27 PST

<rdar://problem/48478526>

Note You need to log in before you can comment on or make changes to this bug.