Bug 194958 - Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
Summary: Stop using legacy IDB path by default when creating WebProcessPool from websi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
Keywords: InRadar
Depends on:
Reported: 2019-02-22 13:01 PST by Sihui Liu
Modified: 2019-02-28 10:17 PST (History)
3 users (show)

See Also:

Patch (10.13 KB, patch)
2019-02-22 13:21 PST, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-02-22 13:01:01 PST
ProcessPoolConfiguration::ProcessPoolConfiguration() uses WebsiteDataStore::defaultIndexedDBDatabaseDirectory(), but ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration(const WebKit::WebsiteDataStoreConfiguration&) always uses WebsiteDataStore::legacyDefaultIndexedDBDatabaseDirectory().
Therefore it's possible we operate on different directories when using WKWebsiteDataStore.
Comment 1 Sihui Liu 2019-02-22 13:21:09 PST
Created attachment 362756 [details]
Comment 2 Geoffrey Garen 2019-02-23 09:20:11 PST
Comment on attachment 362756 [details]

Comment 3 WebKit Commit Bot 2019-02-28 10:15:27 PST
Comment on attachment 362756 [details]

Clearing flags on attachment: 362756

Committed r242203: <https://trac.webkit.org/changeset/242203>
Comment 4 WebKit Commit Bot 2019-02-28 10:15:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-28 10:17:27 PST