Bug 194937

Summary: Avoid hashing CompactVariableEnvironment when decoding CompactVariableMap::Handle
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 194706    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Tadeu Zagallo 2019-02-22 00:53:55 PST
Per Saam's suggestion in https://bugs.webkit.org/show_bug.cgi?id=194706, hashing the CompactVariableEnvironment is expensive and we could avoid it when decoding multiple handles to the same environment.
Comment 1 Tadeu Zagallo 2019-02-22 00:59:26 PST
Created attachment 362705 [details]
Patch
Comment 2 Tadeu Zagallo 2019-02-25 10:16:54 PST
Created attachment 362908 [details]
Patch

Rebase
Comment 3 Saam Barati 2019-02-25 11:27:52 PST
Comment on attachment 362908 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-02-25 12:15:59 PST
Comment on attachment 362908 [details]
Patch

Clearing flags on attachment: 362908

Committed r242054: <https://trac.webkit.org/changeset/242054>
Comment 5 WebKit Commit Bot 2019-02-25 12:16:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-25 12:16:34 PST
<rdar://problem/48372417>