Bug 194929

Summary: Web Inspector: propagate whether to show prototype information to subobject views
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 198721    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-02-21 19:31:28 PST
`_includeProtoProperty` is only set on the top-level `WI.ObjectTreeView`, not any of the child `WI.ObjectTreeBaseTreeElement`. As a result, we see "Object prototype" for logs like `{a: {b: {c: 42}}}`.
Attachments
Patch (5.78 KB, patch)
2019-06-01 13:05 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-01 13:05:48 PDT
Created attachment 371122 [details] Patch
Matt Baker
Comment 2 2019-06-02 16:03:58 PDT
Comment on attachment 371122 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2019-06-02 16:34:41 PDT
Comment on attachment 371122 [details] Patch Clearing flags on attachment: 371122 Committed r246025: <https://trac.webkit.org/changeset/246025>
WebKit Commit Bot
Comment 4 2019-06-02 16:34:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-06-02 16:35:39 PDT
<rdar://problem/51342180>
Note You need to log in before you can comment on or make changes to this bug.