Summary: | NetworkDataTask redirection should not keep alive its NetworkSession | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, ews-watchlist, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2019-02-21 17:55:23 PST
Created attachment 362680 [details]
Patch
Comment on attachment 362680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362680&action=review > Source/WebKit/NetworkProcess/NetworkDataTask.h:80 > +class NetworkDataTask : public RefCounted<NetworkDataTask>, CanMakeWeakPtr<NetworkDataTask> { Need protected or public on CanMakeWeakPtr so it can be used in a class derived from this one. Or could put CanMakeWeakPtr on NetworkDataTaskCocoa instead. Created attachment 362732 [details]
Patch
Comment on attachment 362732 [details] Patch Attachment 362732 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11250465 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html Created attachment 362763 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
|