Bug 194927

Summary: NetworkDataTask redirection should not keep alive its NetworkSession
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Alex Christensen 2019-02-21 17:55:23 PST
NetworkDataTask redirection should not keep alive its NetworkSession
Comment 1 Alex Christensen 2019-02-21 17:55:52 PST
Created attachment 362680 [details]
Patch
Comment 2 Darin Adler 2019-02-21 20:16:17 PST
Comment on attachment 362680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362680&action=review

> Source/WebKit/NetworkProcess/NetworkDataTask.h:80
> +class NetworkDataTask : public RefCounted<NetworkDataTask>, CanMakeWeakPtr<NetworkDataTask> {

Need protected or public on CanMakeWeakPtr so it can be used in a class derived from this one. Or could put CanMakeWeakPtr on NetworkDataTaskCocoa instead.
Comment 3 Alex Christensen 2019-02-22 10:50:42 PST
Created attachment 362732 [details]
Patch
Comment 4 EWS Watchlist 2019-02-22 14:05:47 PST
Comment on attachment 362732 [details]
Patch

Attachment 362732 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11250465

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
Comment 5 EWS Watchlist 2019-02-22 14:05:48 PST
Created attachment 362763 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 Alex Christensen 2019-03-01 18:41:32 PST
http://trac.webkit.org/r242304
Comment 7 Radar WebKit Bug Importer 2019-03-01 18:42:32 PST
<rdar://problem/48531046>