webkitpy: Forward HOME to XPC processes

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Jonathan Bedard]

I think we should be forwarding the HOME environment variable child XPC processes, although I need to do a bit more testing to verify.

[Jonathan Bedard]

<rdar://problem/48135951>

[Jonathan Bedard]

Created attachment 362643 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 362643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362643&action=review

> Tools/Scripts/webkitpy/port/driver.py:415
> +        environment['__XPC_HOME'] = environment.get('HOME')

I don't understand why this became necessary now.

Did you reproduce the problem, and see it fixed with this change? Even if so, we probably need better understanding of the problem than what I saw documented yet.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 362643 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362643&action=review
> 
> > Tools/Scripts/webkitpy/port/driver.py:415
> > +        environment['__XPC_HOME'] = environment.get('HOME')
> 
> I don't understand why this became necessary now.
> 
> Did you reproduce the problem, and see it fixed with this change? Even if
> so, we probably need better understanding of the problem than what I saw
> documented yet.

Sorry, no, I have not yet been able to reproduce the problem. I just wanted to draft the patch, I didn't intend to put it up for review yet, actually.

[Jonathan Bedard]

Upon further investigation, this change is not needed. Closing this bug.