Summary: | Web Inspector: macOS user agent option should be available in device settings menu | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Devin Rousso
2019-02-20 17:07:22 PST
Created attachment 362586 [details]
Patch
Comment on attachment 362586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:2074 > + { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" }, I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are. > Source/WebInspectorUI/UserInterface/Base/Main.js:2076 > + ], > [ Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad. We could even consider a watchOS UserAgent. Comment on attachment 362586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:2074 >> + { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" }, > > I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are. I got this from the most recent developer beta. One annoying thing about this is that we're going to have to update this (and the others) when the system updates. Perhaps we can add something to `InpsectorFrontendHost`. >> Source/WebInspectorUI/UserInterface/Base/Main.js:2076 >> [ > > Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad. > We could even consider a watchOS UserAgent. This matches the current develop menu's structure. Comment on attachment 362586 [details] Patch Clearing flags on attachment: 362586 Committed r241870: <https://trac.webkit.org/changeset/241870> All reviewed patches have been landed. Closing bug. |