Summary: | Web Inspector: eliminate manual syncing of numeric constants used by JavaScript and CSS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||
Priority: | P5 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 195689 | ||||||||
Attachments: |
|
Description
Matt Baker
2019-02-20 16:43:32 PST
Created attachment 364220 [details]
Patch
Comment on attachment 364220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364220&action=review r=me > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:117 > + static get _memoryCategoryViewheight() { return 75; } Typo: "...Viewheight" => "...ViewHeight" I also really dislike _ prefixed getters. They are very confusing / unexpected to work work and this is a constant that doesn't need to be "private". > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:119 > +.network-table .cell.name > .status { > + -webkit-margin-left: 4px; > +} Seems like this should be `-webkit-margin-start` not `-webkit-margin-left`. The sync changes and the -webkit-margin changes should really be different patches. They are almost entirely unrelated changes each with their own possibility of causing regressions. > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:201 > + static get _nodeWaterfallDOMEventSize() { return 8; } Same, this doesn't need to be underscore prefixed. Created attachment 364280 [details]
Patch
Comment on attachment 364280 [details] Patch Clearing flags on attachment: 364280 Committed r242737: <https://trac.webkit.org/changeset/242737> All reviewed patches have been landed. Closing bug. |