Bug 194881

Summary: [PSON] Make sure hung processes are not kept alive by suspended pages or process caching
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-02-20 16:12:22 PST
Make sure hung processes are not kept alive by suspended pages or process caching.
Attachments
Patch (12.39 KB, patch)
2019-02-20 16:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-02-20 16:12:36 PST
<rdar://problem/48249014>
Chris Dumez
Comment 2 2019-02-20 16:19:21 PST
Created attachment 362564 [details] Patch
Ryosuke Niwa
Comment 3 2019-02-20 16:25:46 PST
Comment on attachment 362564 [details] Patch Is it possible for the process to start using a lot of CPU after it had entered the cache? Maybe we need to kill those processes retroactively as well?
Geoffrey Garen
Comment 4 2019-02-20 16:27:39 PST
Comment on attachment 362564 [details] Patch r=me
Chris Dumez
Comment 5 2019-02-20 16:28:24 PST
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 362564 [details] > Patch > > Is it possible for the process to start using a lot of CPU after it had > entered the cache? > Maybe we need to kill those processes retroactively as well? I do not think this is possible, such processes have no WebPages anymore. Running JS is normally the issue.
WebKit Commit Bot
Comment 6 2019-02-20 17:25:52 PST
Comment on attachment 362564 [details] Patch Clearing flags on attachment: 362564 Committed r241855: <https://trac.webkit.org/changeset/241855>
WebKit Commit Bot
Comment 7 2019-02-20 17:25:54 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2019-02-21 09:25:17 PST
Follow-up fix for API tests in <https://trac.webkit.org/changeset/241868>.
Chris Dumez
Comment 9 2019-02-21 15:59:51 PST
Another follow-up fix: <https://trac.webkit.org/changeset/241919>
Note You need to log in before you can comment on or make changes to this bug.