Bug 194876

Summary: [Win] Remove CF when using Windows clipboard
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175336    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2019-02-20 15:32:21 PST
ClipboardUtilitiesWin.cpp DragDataWin.cpp and PasteboardWin.cpp all have USE(CF) guards which have minimal requirements on CF. Need to replace urlFromPath within ClipboardUtilitiesWin and then all the guards can be removed completely.
Attachments
Patch (4.67 KB, patch)
2021-12-08 14:25 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-12-08 14:25:20 PST
Created attachment 446420 [details] Patch
Brent Fulgham
Comment 2 2021-12-08 14:43:03 PST
Comment on attachment 446420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446420&action=review r=me > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:468 > + url = URL::fileURLWithFileSystemPath(String(data)).fileSystemPath(); Very nice!
EWS
Comment 3 2021-12-08 16:33:23 PST
Committed r286752 (244995@main): <https://commits.webkit.org/244995@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446420 [details].
Radar WebKit Bug Importer
Comment 4 2021-12-08 16:34:20 PST
<rdar://problem/86240474>
Note You need to log in before you can comment on or make changes to this bug.