Bug 194876

Summary:

[Win] Remove CF when using Windows clipboard

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Platform

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

175336

Attachments:

Description	Flags
Patch	none

Description Don Olmstead 2019-02-20 15:32:21 PST

ClipboardUtilitiesWin.cpp DragDataWin.cpp and PasteboardWin.cpp all have USE(CF) guards which have minimal requirements on CF.

Need to replace urlFromPath within ClipboardUtilitiesWin and then all the guards can be removed completely.

Comment 1 Don Olmstead 2021-12-08 14:25:20 PST

Created attachment 446420 [details]
Patch

Comment 2 Brent Fulgham 2021-12-08 14:43:03 PST

Comment on attachment 446420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446420&action=review

r=me

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:468
> +                url = URL::fileURLWithFileSystemPath(String(data)).fileSystemPath();

Very nice!

Comment 3 EWS 2021-12-08 16:33:23 PST

Committed r286752 (244995@main): <https://commits.webkit.org/244995@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446420 [details].

Comment 4 Radar WebKit Bug Importer 2021-12-08 16:34:20 PST

<rdar://problem/86240474>