Bug 194836

Summary: [bmalloc] bmalloc::Heap is allocated even though we use system malloc mode
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2019-02-19 15:29:33 PST
...
Comment 1 Yusuke Suzuki 2019-02-19 21:22:10 PST
Created attachment 362481 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-19 21:43:56 PST
Created attachment 362482 [details]
Patch
Comment 3 Mark Lam 2019-02-19 22:04:41 PST
Comment on attachment 362482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362482&action=review

r=me.  Can you run PerformanceTests/MallocBench just to be sure that there's no significant perf difference?

> Source/bmalloc/bmalloc/bmalloc.cpp:71
> +        {
> +            std::unique_lock<Mutex> lock(Heap::mutex());
> +            result = heap.tryAllocateLarge(lock, alignment, size);
> +            if (result) {
> +                // Don't track this as dirty memory that dictates how we drive the scavenger.
> +                // FIXME: We should make it so that users of this API inform bmalloc which
> +                // pages they dirty:
> +                // https://bugs.webkit.org/show_bug.cgi?id=184207
> +                heap.externalDecommit(lock, result, size);
> +            }
>          }

No need to indent one more level here.  You're already inside a scope unlike before.
Comment 4 Yusuke Suzuki 2019-02-20 15:39:20 PST
Comment on attachment 362482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362482&action=review

I ran MallocBench and it was performance neutral.

>> Source/bmalloc/bmalloc/bmalloc.cpp:71
>>          }
> 
> No need to indent one more level here.  You're already inside a scope unlike before.

Fixed, thanks.
Comment 5 Yusuke Suzuki 2019-02-20 16:03:27 PST
Committed r241847: <https://trac.webkit.org/changeset/241847>
Comment 6 Radar WebKit Bug Importer 2019-02-20 16:04:40 PST
<rdar://problem/48256231>