Summary: | Reduce use of LegacySync IPC message type | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2019-02-19 15:24:52 PST
Created attachment 362444 [details]
Patch
Comment on attachment 362444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362444&action=review > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:464 > + completionHandler(result.first, result.second); I think WTFMove(result.first) would save a tiny bit of reference count churn. > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:487 > + completionHandler(result.first, result.second); I think WTFMove(result.first) would save a tiny bit of reference count churn. > Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:254 > + return completionHandler(false); There it is, one of those return void things. > Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:261 > + completionHandler(true); But no return here. What about if you refactor and add a return value? (Just kidding.) |