Bug 194835

Summary: Reduce use of LegacySync IPC message type
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Alex Christensen 2019-02-19 15:24:52 PST
Reduce use of LegacySync IPC message type
Comment 1 Alex Christensen 2019-02-19 15:27:56 PST
Created attachment 362444 [details]
Patch
Comment 2 Darin Adler 2019-02-21 19:22:39 PST
Comment on attachment 362444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362444&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:464
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:487
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:254
> +        return completionHandler(false);

There it is, one of those return void things.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:261
> +    completionHandler(true);

But no return here. What about if you refactor and add a return value? (Just kidding.)
Comment 3 Alex Christensen 2019-03-20 16:38:08 PDT
http://trac.webkit.org/r243258
Comment 4 Radar WebKit Bug Importer 2019-03-20 16:43:21 PDT
<rdar://problem/49085284>