Summary: | test262-runner ends with SIGPIPE signal | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, cgarcia, commit-queue, ews-feeder, keith_miller, lforschler, mcatanzaro, msaboff, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Diego Pino
2019-02-19 05:31:34 PST
Created attachment 362382 [details]
Patch
Explanation of the patch. I debugged the issue using 'Carp::Trace'. I captured SIGPIPE signals and printed out a trace. I got the following output: ``` Test262::Runner::main [3] scalar - new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 122 Test262::Runner::(eval) [2] scalar - no new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416 Test262::Runner::__ANON__ [1] scalar - new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416 ``` This pattern occurred several times in the output. IIRC, a SIGPIPE happens when attempting to write on a closed pipe. In the case of the suspecting line (416), I think what is happening if that child is trying to write on a closed socket (the parent was closed right before that loop). In any case, it seems to me this block of code is redundant, so I removed it. After applying the patch, `test262-runner --release` runs just fine (exit status is 0). Created attachment 384441 [details]
Patch
Comment on attachment 384441 [details]
Patch
Carlos López reviewed the patch and granted r+ on private conversation.
Comment on attachment 384441 [details] Patch Rejecting attachment 384441 [details] from review queue. dpino@igalia.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 384441 [details] Patch Clearing flags on attachment: 384441 Committed r252930: <https://trac.webkit.org/changeset/252930> All reviewed patches have been landed. Closing bug. |