Bug 194774

Summary: WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: New BugsAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dbates, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Claudio Saavedra 2019-02-18 04:41:11 PST 
WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports
Comment 1 Claudio Saavedra 2019-02-18 04:41:31 PST 
Created attachment 362290 [details]
Patch
Comment 2 Claudio Saavedra 2019-02-18 06:44:43 PST 
This was introduced in https://trac.webkit.org/changeset/241451/
Comment 3 Alex Christensen 2019-02-18 12:46:59 PST 
Comment on attachment 362290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362290&action=review

Null checking navigation before using it is fine, but the way you did it here makes it hard to read and see where the assignment is done.  Could we keep the assignment on its own line?

> Source/WebKit/ChangeLog:3
> +        WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports

Why is this only WPE and GTK?  Under what conditions does it crash?
Comment 4 Alex Christensen 2019-02-18 13:30:48 PST 
Comment on attachment 362290 [details]
Patch

https://trac.webkit.org/changeset/241735/webkit
Comment 5 Radar WebKit Bug Importer 2019-02-18 13:39:37 PST 
<rdar://problem/48176470>