Bug 194743

Summary: [JSC] JSWrapperObject should not be destructible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2019-02-16 01:33:26 PST
[JSC] JSWrapperObject should not be destructible
Attachments
Patch (20.31 KB, patch)
2019-02-16 01:54 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-16 01:54:59 PST
Created attachment 362214 [details] Patch
Saam Barati
Comment 2 2019-02-16 02:19:35 PST
Comment on attachment 362214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review > Source/JavaScriptCore/ChangeLog:10 > + JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible. Typo: JSWrapperObjec
Yusuke Suzuki
Comment 3 2019-02-16 10:41:39 PST
Comment on attachment 362214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible. > > Typo: JSWrapperObjec Thanks, fixed!
Yusuke Suzuki
Comment 4 2019-02-16 10:50:18 PST
Committed r241649: <https://trac.webkit.org/changeset/241649>
Radar WebKit Bug Importer
Comment 5 2019-02-16 10:51:23 PST
<rdar://problem/48139806>
Note You need to log in before you can comment on or make changes to this bug.