Bug 194743

Summary: [JSC] JSWrapperObject should not be destructible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sbarati: review+

Description Yusuke Suzuki 2019-02-16 01:33:26 PST
[JSC] JSWrapperObject should not be destructible
Comment 1 Yusuke Suzuki 2019-02-16 01:54:59 PST
Created attachment 362214 [details]
Patch
Comment 2 Saam Barati 2019-02-16 02:19:35 PST
Comment on attachment 362214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible.

Typo: JSWrapperObjec
Comment 3 Yusuke Suzuki 2019-02-16 10:41:39 PST
Comment on attachment 362214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible.
> 
> Typo: JSWrapperObjec

Thanks, fixed!
Comment 4 Yusuke Suzuki 2019-02-16 10:50:18 PST
Committed r241649: <https://trac.webkit.org/changeset/241649>
Comment 5 Radar WebKit Bug Importer 2019-02-16 10:51:23 PST
<rdar://problem/48139806>