Bug 194739

Summary:

[LFC] Apply min/max width constraints to preferred width computation

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description zalan 2019-02-15 21:14:39 PST

ssia

Comment 1 zalan 2019-02-15 21:23:27 PST

Created attachment 362206 [details]
Patch

Comment 2 Simon Fraser (smfr) 2019-02-15 22:03:14 PST

Comment on attachment 362206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362206&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:309
> +            auto& formattingState = layoutState.formattingStateForBox(child);

Could that be const auto&?

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:315
> +            auto marginBorderAndPadding =  fixedValue(childStyle.marginStart()).valueOr(0)

Extra space

Comment 3 zalan 2019-02-16 04:54:07 PST

Committed r241646: <https://trac.webkit.org/changeset/241646>

Comment 4 Radar WebKit Bug Importer 2019-02-16 04:55:30 PST

<rdar://problem/48137982>