| Summary: | NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=194737 | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2019-02-15 16:40:44 PST
Created attachment 362182 [details]
Patch
Comment on attachment 362182 [details]
Patch
r=me
Can we test this with an API test for TLS certificate check?
> Can we test this with an API test for TLS certificate check?
API test probably not since we would need an HTTPS server, which we do no have yet.
We might be able to test it as a layout test with:
- a testRunner API to not respond to the certificate validation request.
- a case where network load is nullified without being cancelled. A navigation load, intercepted by fetch and leading to a fetch redirect mode=manual might do the trick.
(In reply to youenn fablet from comment #4) > > Can we test this with an API test for TLS certificate check? > > API test probably not since we would need an HTTPS server, which we do no > have yet. > We might be able to test it as a layout test with: > - a testRunner API to not respond to the certificate validation request. To delay otherwise, the load will not complete. Comment on attachment 362182 [details] Patch Clearing flags on attachment: 362182 Committed r241641: <https://trac.webkit.org/changeset/241641> All reviewed patches have been landed. Closing bug. |