Bug 194732

Summary: NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194737
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2019-02-15 16:40:44 PST
NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics <rdar://problem/47833813>
Attachments
Patch (1.82 KB, patch)
2019-02-15 16:46 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-02-15 16:46:25 PST
Created attachment 362182 [details] Patch
youenn fablet
Comment 2 2019-02-15 16:46:58 PST
<rdar://problem/47833813>
Geoffrey Garen
Comment 3 2019-02-15 19:52:02 PST
Comment on attachment 362182 [details] Patch r=me Can we test this with an API test for TLS certificate check?
youenn fablet
Comment 4 2019-02-15 20:26:43 PST
> Can we test this with an API test for TLS certificate check? API test probably not since we would need an HTTPS server, which we do no have yet. We might be able to test it as a layout test with: - a testRunner API to not respond to the certificate validation request. - a case where network load is nullified without being cancelled. A navigation load, intercepted by fetch and leading to a fetch redirect mode=manual might do the trick.
youenn fablet
Comment 5 2019-02-15 20:28:58 PST
(In reply to youenn fablet from comment #4) > > Can we test this with an API test for TLS certificate check? > > API test probably not since we would need an HTTPS server, which we do no > have yet. > We might be able to test it as a layout test with: > - a testRunner API to not respond to the certificate validation request. To delay otherwise, the load will not complete.
youenn fablet
Comment 6 2019-02-15 20:29:57 PST
Filed https://bugs.webkit.org/show_bug.cgi?id=194737
WebKit Commit Bot
Comment 7 2019-02-15 20:57:14 PST
Comment on attachment 362182 [details] Patch Clearing flags on attachment: 362182 Committed r241641: <https://trac.webkit.org/changeset/241641>
WebKit Commit Bot
Comment 8 2019-02-15 20:57:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.