Bug 194729

Summary: Web Inspector: Dark Mode: commas in CSS selectors are too dim
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
Patch
none
[Image] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2019-02-15 16:14:28 PST
Created attachment 362175 [details] [Image] Bug Commas in CSS selectors and curly braces around style declarations are barely visible in Dark Mode.
Attachments
[Image] Bug (85.61 KB, image/png)
2019-02-15 16:14 PST, Nikita Vasilyev 		no flags
Details
Patch (1.43 KB, patch)
2019-02-15 16:18 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2019-02-15 16:31 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (79.09 KB, image/png)
2019-02-15 16:33 PST, Nikita Vasilyev 		no flags
Details
Patch (3.62 KB, patch)
2019-02-15 17:16 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-02-15 16:18:26 PST
Created attachment 362177 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-15 16:18:45 PST
<rdar://problem/48128592>
Nikita Vasilyev
Comment 3 2019-02-15 16:31:36 PST
Created attachment 362180 [details] Patch
Nikita Vasilyev
Comment 4 2019-02-15 16:33:07 PST
Created attachment 362181 [details] [Image] With patch applied
Matt Baker
Comment 5 2019-02-15 17:02:29 PST
Comment on attachment 362180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33 > border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2); This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode?
Nikita Vasilyev
Comment 6 2019-02-15 17:15:50 PST
Comment on attachment 362180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33 >> border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2); > > This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode? Good point!
Nikita Vasilyev
Comment 7 2019-02-15 17:16:25 PST
Created attachment 362191 [details] Patch
Matt Baker
Comment 8 2019-02-15 17:37:09 PST
Comment on attachment 362191 [details] Patch r=me, looks good!
WebKit Commit Bot
Comment 9 2019-02-15 18:03:38 PST
Comment on attachment 362191 [details] Patch Clearing flags on attachment: 362191 Committed r241638: <https://trac.webkit.org/changeset/241638>
WebKit Commit Bot
Comment 10 2019-02-15 18:03:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.