Summary: | Web Inspector: Dark Mode: commas in CSS selectors are too dim | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Created attachment 362177 [details]
Patch
Created attachment 362180 [details]
Patch
Created attachment 362181 [details]
[Image] With patch applied
Comment on attachment 362180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33 > border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2); This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode? Comment on attachment 362180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33 >> border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2); > > This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode? Good point! Created attachment 362191 [details]
Patch
Comment on attachment 362191 [details]
Patch
r=me, looks good!
Comment on attachment 362191 [details] Patch Clearing flags on attachment: 362191 Committed r241638: <https://trac.webkit.org/changeset/241638> All reviewed patches have been landed. Closing bug. |
Created attachment 362175 [details] [Image] Bug Commas in CSS selectors and curly braces around style declarations are barely visible in Dark Mode.