Web Inspector: Dark Mode: commas in CSS selectors are too dim

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Created attachment 362175 [details]
[Image] Bug

Commas in CSS selectors and curly braces around style declarations are barely visible in Dark Mode.

[Nikita Vasilyev]

Created attachment 362177 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/48128592>

[Nikita Vasilyev]

Created attachment 362180 [details]
Patch

[Nikita Vasilyev]

Created attachment 362181 [details]
[Image] With patch applied

[Matt Baker]

Comment on attachment 362180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33
>      border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);

This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode?

[Nikita Vasilyev]

Comment on attachment 362180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33
>>      border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);
> 
> This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode?

Good point!

[Nikita Vasilyev]

Created attachment 362191 [details]
Patch

[Matt Baker]

Comment on attachment 362191 [details]
Patch

r=me, looks good!

[WebKit Commit Bot]

Comment on attachment 362191 [details]
Patch

Clearing flags on attachment: 362191

Committed r241638: <https://trac.webkit.org/changeset/241638>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.