Bug 194703

Summary: Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+
Patch for landing none

Description Wenson Hsieh 2019-02-15 07:11:28 PST 
This should be formatSetBlockTextDirection instead.
Comment 1 Radar WebKit Bug Importer 2019-02-15 08:49:23 PST 
<rdar://problem/48111775>
Comment 2 Wenson Hsieh 2019-02-15 20:52:44 PST 
Created attachment 362205 [details]
Patch
Comment 3 Ryosuke Niwa 2019-02-21 21:05:05 PST 
Comment on attachment 362205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362205&action=review

> Source/WebCore/editing/EditAction.cpp:78
> +    case EditAction::SetTextWritingDirection:
> +    case EditAction::SetBaseWritingDirection:

I would have preferred using inline & block to match input type names.
Comment 4 Wenson Hsieh 2019-02-21 21:08:01 PST 
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 362205 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362205&action=review
> 
> > Source/WebCore/editing/EditAction.cpp:78
> > +    case EditAction::SetTextWritingDirection:
> > +    case EditAction::SetBaseWritingDirection:
> 
> I would have preferred using inline & block to match input type names.

Sounds good — I'll change these to EditAction::SetInlineWritingDirection and EditAction::SetBlockWritingDirection.
Comment 5 Wenson Hsieh 2019-02-22 08:32:03 PST 
Created attachment 362723 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-02-22 09:09:34 PST 
Comment on attachment 362723 [details]
Patch for landing

Clearing flags on attachment: 362723

Committed r241949: <https://trac.webkit.org/changeset/241949>