Summary: | [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mark.lam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2019-02-15 00:41:56 PST
Created attachment 362103 [details]
Patch
Comment on attachment 362103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review r=me with suggested improvement. > Source/bmalloc/bmalloc/Gigacage.cpp:271 > bool result = !PerProcess<Environment>::get()->isDebugHeapEnabled(); > if (!result) This is not related to your patch but since you're in this code, let's fix this too: 1. the name "result" is not meaningful. Let's call it debugHeapEnabled instead. 2. the double negative is hard to follow. Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check. Comment on attachment 362103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review >> Source/bmalloc/bmalloc/Gigacage.cpp:271 >> if (!result) > > This is not related to your patch but since you're in this code, let's fix this too: > 1. the name "result" is not meaningful. Let's call it debugHeapEnabled instead. > 2. the double negative is hard to follow. Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check. Sounds nice! Fixed. Committed r241581: <https://trac.webkit.org/changeset/241581> |