Bug 194674

Summary: [bmalloc] Do not start scavenger thread if we use system malloc
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2019-02-14 14:09:57 PST
...
Attachments
Patch (1.63 KB, patch)
2019-02-14 23:10 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-14 23:10:43 PST
Created attachment 362099 [details] Patch
Yusuke Suzuki
Comment 2 2019-02-14 23:27:20 PST
Comment on attachment 362099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362099&action=review > Source/bmalloc/bmalloc/Scavenger.cpp:72 > + if (PerProcess<Environment>::get()->isDebugHeapEnabled()) > + return; > + For bmalloc::Heap, Large & Small allocations go to debug heap if `isDebugHeapEnabled()` is true. IsoHeaps also allocate memory from system malloc (fallbacking to malloc).
Mark Lam
Comment 3 2019-02-15 00:24:50 PST
Comment on attachment 362099 [details] Patch r=me
Yusuke Suzuki
Comment 4 2019-02-15 00:27:27 PST
Comment on attachment 362099 [details] Patch Thank you!
WebKit Commit Bot
Comment 5 2019-02-15 00:43:13 PST
Comment on attachment 362099 [details] Patch Clearing flags on attachment: 362099 Committed r241580: <https://trac.webkit.org/changeset/241580>
WebKit Commit Bot
Comment 6 2019-02-15 00:43:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-02-15 00:45:37 PST
<rdar://problem/48104040>
Note You need to log in before you can comment on or make changes to this bug.