Bug 194670

Summary: [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First pass
none
Patch for EWS
none
Patch for EWS none

Wenson Hsieh
Reported 2019-02-14 13:51:23 PST
<rdar://problem/39066529>
Attachments
First pass (66.98 KB, patch)
2019-02-14 15:51 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for EWS (65.04 KB, patch)
2019-02-18 14:51 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for EWS (64.13 KB, patch)
2019-02-18 14:57 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-02-14 15:51:31 PST
Created attachment 362074 [details] First pass
Tim Horton
Comment 2 2019-02-18 13:22:00 PST
Comment on attachment 362074 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=362074&action=review > Source/WebCore/platform/ios/PasteboardIOS.mm:291 > + bool canReadAttachment = policy == WebContentReadingPolicy::AnyType && RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled(); Maybe put attachmentELementEnabled outside the loop and bail from this whole section if it's not set? > Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:34 > - typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1, WKBundlePageEditorClientV2> Versions; > + typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1> Versions; Did we ever ship this? I think you noted that nobody adopted, but did we ship it?
Wenson Hsieh
Comment 3 2019-02-18 13:50:13 PST
Comment on attachment 362074 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=362074&action=review >> Source/WebCore/platform/ios/PasteboardIOS.mm:291 >> + bool canReadAttachment = policy == WebContentReadingPolicy::AnyType && RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled(); > > Maybe put attachmentELementEnabled outside the loop and bail from this whole section if it's not set? 👍 >> Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:34 >> + typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1> Versions; > > Did we ever ship this? I think you noted that nobody adopted, but did we ship it? Regrettably, this did ship :( Per IRC conversation, I'll maintain bincompat in this patch, and then see if I can remove it in a separate patch.
Wenson Hsieh
Comment 4 2019-02-18 14:51:11 PST
Created attachment 362338 [details] Patch for EWS
Wenson Hsieh
Comment 5 2019-02-18 14:57:04 PST
Created attachment 362341 [details] Patch for EWS
WebKit Commit Bot
Comment 6 2019-02-18 16:43:47 PST
Comment on attachment 362341 [details] Patch for EWS Clearing flags on attachment: 362341 Committed r241749: <https://trac.webkit.org/changeset/241749>
WebKit Commit Bot
Comment 7 2019-02-18 16:43:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.