Bug 194666

Summary: Make navigator.mediaDevices SecureContext
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, jonlee, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220184
Bug Depends on:    
Bug Blocks: 194713    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-02-14 13:08:36 PST
Make navigator.mediaDevices SecureContext
Attachments
Patch (7.15 KB, patch)
2019-02-14 14:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.21 KB, patch)
2019-02-14 15:55 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.22 KB, patch)
2019-02-15 10:44 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-02-14 14:21:50 PST
Created attachment 362061 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-02-14 14:22:50 PST
<rdar://problem/48088224>
youenn fablet
Comment 3 2019-02-14 15:55:48 PST
Created attachment 362076 [details] Patch
Eric Carlson
Comment 4 2019-02-15 09:55:21 PST
Comment on attachment 362076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362076&action=review > Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35 > + [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices; Nit: I think something like "ContextAllowsMediaDevices" might be clearer.
youenn fablet
Comment 5 2019-02-15 09:57:22 PST
(In reply to Eric Carlson from comment #4) > Comment on attachment 362076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362076&action=review > > > Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35 > > + [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices; > > Nit: I think something like "ContextAllowsMediaDevices" might be clearer. Yes, makes sense!
youenn fablet
Comment 6 2019-02-15 10:44:32 PST
Created attachment 362128 [details] Patch for landing
Jon Lee
Comment 7 2019-02-15 11:05:52 PST
Comment on attachment 362128 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=362128&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695 > + . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())"); Do we not add binding generator tests for extended attributes such as these?
youenn fablet
Comment 8 2019-02-15 11:08:14 PST
(In reply to Jon Lee from comment #7) > Comment on attachment 362128 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362128&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695 > > + . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())"); > > Do we not add binding generator tests for extended attributes such as these? Filed https://bugs.webkit.org/show_bug.cgi?id=194713
WebKit Commit Bot
Comment 9 2019-02-15 11:22:40 PST
Comment on attachment 362128 [details] Patch for landing Clearing flags on attachment: 362128 Committed r241602: <https://trac.webkit.org/changeset/241602>
WebKit Commit Bot
Comment 10 2019-02-15 11:22:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.