Bug 194647

Summary: AX: ARIA Reflection was disabled in error
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
rniwa: review+
Landing patch none

Description James Craig 2019-02-14 01:32:17 PST 
AX: ARIA Reflection was disabled in error

r236522 from bug 151380 disabled the ARIAReflectionEnabled flag, presumably in error.
https://bugs.webkit.org/show_bug.cgi?id=151380#c18

The automated tests did not catch the fault because the test runner overrides the flag:

~src/WebKit/Tools/WebKitTestRunner/TestController.cpp:
  827:     WKPreferencesSetAriaReflectionEnabled(preferences, true);
  
So the fix may be to revert the AriaReflectionEnabled value in WebPreferences.yaml and remove the test override.
Comment 1 James Craig 2019-02-14 01:37:46 PST 
<rdar://problem/48068336>
Comment 2 chris fleizach 2019-02-14 01:40:20 PST 
Created attachment 362005 [details]
patch
Comment 3 James Craig 2019-02-14 01:49:03 PST 
Comment on attachment 362005 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1438
> +  defaultValue: true

Should this patch pull the test override out too? 

~src/WebKit/Tools/WebKitTestRunner/TestController.cpp:
  827:     WKPreferencesSetAriaReflectionEnabled(preferences, true);
Comment 4 chris fleizach 2019-02-14 01:49:42 PST 
Comment on attachment 362005 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1438
>> +  defaultValue: true
> 
> Should this patch pull the test override out too? 
> 
> ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp:
>   827:     WKPreferencesSetAriaReflectionEnabled(preferences, true);

will wait for Ryosuke to weigh in on that
Comment 5 Ryosuke Niwa 2019-02-14 02:30:04 PST 
Comment on attachment 362005 [details]
patch

We probably should remove the override in the test runner as well
Comment 6 chris fleizach 2019-02-14 08:05:45 PST 
Created attachment 362016 [details]
Landing patch
Comment 7 WebKit Commit Bot 2019-02-14 09:27:25 PST 
Comment on attachment 362016 [details]
Landing patch

Clearing flags on attachment: 362016

Committed r241549: <https://trac.webkit.org/changeset/241549>
Comment 8 WebKit Commit Bot 2019-02-14 09:27:26 PST 
All reviewed patches have been landed.  Closing bug.