Bug 194641

Summary: Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, ggaren, koivisto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Description Ryosuke Niwa 2019-02-13 21:36:10 PST 
When WKBundleFrameGetParentFrame is called inside PageLoaderClient's didRemoveFrameFromHierarchy,
we crash WebFrame::parentFrame() because owner element's document no longer has a frame.
Comment 1 Ryosuke Niwa 2019-02-13 21:43:21 PST 
Created attachment 361994 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2019-02-13 21:43:46 PST 
<rdar://problem/31441007>
Comment 3 Geoffrey Garen 2019-02-13 22:09:18 PST 
Comment on attachment 361994 [details]
Fixes the bug

r=me
Comment 4 Ryosuke Niwa 2019-02-13 22:47:33 PST 
Comment on attachment 361994 [details]
Fixes the bug

Clearing flags on attachment: 361994

Committed r241500: <https://trac.webkit.org/changeset/241500>
Comment 5 Ryosuke Niwa 2019-02-13 22:47:35 PST 
All reviewed patches have been landed.  Closing bug.