Bug 194623

Summary: Web Inspector: don't include accessibility role in DOM.Node object payloads
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, drousso, ews-watchlist, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch drousso: review+, drousso: commit-queue-

Description BJ Burg 2019-02-13 16:27:26 PST
This is complicated to fetch at all the points where we want to build and push nodes immediately. Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the first place due to a DOM node tree update (i.e., NodeInserted).
Comment 1 BJ Burg 2019-02-13 16:27:42 PST
<rdar://problem/36384037>
Comment 2 BJ Burg 2019-02-13 16:31:48 PST
Created attachment 361957 [details]
Patch
Comment 3 EWS Watchlist 2019-02-13 16:33:52 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 4 Devin Rousso 2019-02-13 16:39:49 PST
Comment on attachment 361957 [details]
Patch

r=me

We should also update `WI.DOMNode.prototype.accessibilityProperties` to save the role to `_computedRole` so that `WI.DOMNode.prototype.computedRole` actually returns a value once we've requested accessibility info at least once (this is needed by `WI.roleSelectorForNode`).
Comment 5 BJ Burg 2019-02-14 09:06:13 PST
Committed r241547: <https://trac.webkit.org/changeset/241547>