Summary: | [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, graouts, jonlee, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2019-02-13 15:51:59 PST
Created attachment 361951 [details]
Patch
Comment on attachment 361951 [details] Patch Clearing flags on attachment: 361951 Committed r241492: <https://trac.webkit.org/changeset/241492> All reviewed patches have been landed. Closing bug. Comment on attachment 361951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361951&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287 > + this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode); @Antoine, why was rAF used in the first place? @Jer, are there other instances where rAF is being used for similar purposes that should be reconsidered? (In reply to Jon Lee from comment #5) > Comment on attachment 361951 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361951&action=review > > > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287 > > + this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode); > > @Antoine, why was rAF used in the first place? I don't know for sure, but I would wager this was to do with flakiness. |