Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations

See Bug 194283.

[Claudio Saavedra]

I see your patch in bug 194283 already does this. What else do you need?

[Claudio Saavedra]

(In reply to Claudio Saavedra from comment #1)
> I see your patch in bug 194283 already does this. What else do you need?

Arg, wrong bug. Ignore this.

[Fujii Hironori]

DumpJSConsoleLogInStdErr expectation is considered a bad idea by some developers.
And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027).
So, I'd like to remove DumpJSConsoleLogInStdErr expectation and use dumpJSConsoleLogInStdErr test option instead.

(In reply to Jonathan Bedard from bug #194283 comment #3)
> This bug very much confuses me. Why would we have a test expectation with
> DumpJSConsoleLogInStdErr in it? That feels like an abuse of the
> TestExpectations.

(In reply to Alexey Proskuryakov from bug #194283 comment #2)
> I think that we are hitting a design mistake with regards to
> DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with
> expectations causes trouble.

(In reply to youenn fablet from bug #161310 comment #4)
> It seems a bit odd to add that keyword to TestExpectations since it is
> becoming more like a setup option. This applies also a bit to Slow keyword.

[Fujii Hironori]

Created attachment 361905 [details]
Patch

[EWS Watchlist]

Comment on attachment 361905 [details]
Patch

Attachment 361905 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11133612

New failing tests:
http/tests/security/frame-loading-via-document-write.html
http/tests/security/cross-origin-cached-images-parallel.html
http/tests/security/frame-loading-via-document-write-async-delegates.html

[EWS Watchlist]

Created attachment 361911 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Fujii Hironori]

Created attachment 361979 [details]
Patch

[EWS Watchlist]

Comment on attachment 361979 [details]
Patch

Attachment 361979 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11142759

New failing tests:
http/tests/security/frame-loading-via-document-write.html
http/tests/security/cross-origin-cached-images-parallel.html
http/tests/security/frame-loading-via-document-write-async-delegates.html

[EWS Watchlist]

Created attachment 361995 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Fujii Hironori]

Win DumpRenderTree is failing to get webkit-test-runner magic comment if run-webkit-tests is running by Cygwin Python.

[Fujii Hironori]

Created attachment 361997 [details]
Patch

[EWS Watchlist]

Comment on attachment 361997 [details]
Patch

Attachment 361997 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11144199

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

[EWS Watchlist]

Created attachment 362004 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Fujii Hironori]

Landed: https://trac.webkit.org/r241656

[Radar WebKit Bug Importer]

<rdar://problem/48151478>