Bug 194581

Summary: Remove unnecessary null check in bindings.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebCore JavaScriptAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 194530    
Bug Blocks:    
Attachments:
Description Flags
proposed patch.
none
proposed patch. none

Mark Lam
Reported 2019-02-12 22:02:55 PST
See https://bugs.webkit.org/show_bug.cgi?id=194530#c10: It is always save to call visitor.containsOpaqueRoot(root) with a null root pointer. It will just return false. Since we don't expect the root pointer to be null in the common case, having a null check here is also not be optimal. We'll remove this unneeded null check.
Attachments
proposed patch. (2.40 KB, patch)
2019-02-12 22:09 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (2.40 KB, patch)
2019-02-12 22:12 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-02-12 22:09:47 PST
Created attachment 361893 [details] proposed patch.
Mark Lam
Comment 2 2019-02-12 22:12:27 PST
Created attachment 361894 [details] proposed patch.
Yusuke Suzuki
Comment 3 2019-02-12 22:47:19 PST
Comment on attachment 361894 [details] proposed patch. r=me
WebKit Commit Bot
Comment 4 2019-02-12 23:13:12 PST
Comment on attachment 361894 [details] proposed patch. Clearing flags on attachment: 361894 Committed r241348: <https://trac.webkit.org/changeset/241348>
WebKit Commit Bot
Comment 5 2019-02-12 23:13:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-02-12 23:14:24 PST
<rdar://problem/48029348>
Note You need to log in before you can comment on or make changes to this bug.