Bug 194570

Summary:

Branch-Specific: Revert ability to set programmatic focus when hardware keyboard is attached

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, dbates, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

190017

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Brent Fulgham

Reported 2019-02-12 17:02:49 PST

Modifying WebKit to allow programmatic focus when a hardware keyboard is attached doesn't work well enough to ship. We should turn this off in our safari-607-branch.

Attachments
Patch (2.25 KB, patch) 2019-02-12 17:05 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2019-02-12 17:04:09 PST

<rdar://problem/47673836>

Brent Fulgham

Comment 2 2019-02-12 17:05:22 PST

Created attachment 361870 [details] Patch

Daniel Bates

Comment 3 2019-02-12 18:24:32 PST

Comment on attachment 361870 [details] Patch Ensure this doesn’t cause any API test failures. I think we may have some tests.

Brent Fulgham

Comment 4 2019-02-14 08:08:41 PST

I ran all API tests with and without this patch and had the same results for all tests. Clearing flag because we do not intend to land this in trunk.

Note You need to log in before you can comment on or make changes to this bug.