Bug 194552

Summary: [WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Justin Fan
Reported 2019-02-12 12:50:55 PST
[WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
Attachments
Patch (37.39 KB, patch)
2019-02-12 13:00 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (37.39 KB, patch)
2019-02-12 13:29 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (37.42 KB, patch)
2019-02-12 14:08 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (37.34 KB, patch)
2019-02-12 14:16 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (38.12 KB, patch)
2019-02-12 15:41 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-02-12 13:00:38 PST
Created attachment 361825 [details] Patch
Justin Fan
Comment 2 2019-02-12 13:29:22 PST
Created attachment 361829 [details] Patch
Justin Fan
Comment 3 2019-02-12 14:08:56 PST
Created attachment 361838 [details] Patch
Justin Fan
Comment 4 2019-02-12 14:16:36 PST
Created attachment 361839 [details] Patch
Dean Jackson
Comment 5 2019-02-12 14:16:47 PST
Comment on attachment 361838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361838&action=review r=me but make sure not to commit the conflicted Sources.txt > Source/WebCore/Sources.txt:2774 > +<<<<<<< HEAD > JSGPUColor.cpp > +======= > +JSGPUBufferDescriptor.cpp > +JSGPUBufferUsage.cpp > +>>>>>>> 57c93d27a40... Removed WebGPUBufferDescriptor/Usage for GPUBufferDescriptor/Usage oops.
Justin Fan
Comment 6 2019-02-12 15:41:10 PST
Created attachment 361855 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-02-12 16:23:16 PST
Comment on attachment 361855 [details] Patch for landing Clearing flags on attachment: 361855 Committed r241328: <https://trac.webkit.org/changeset/241328>
WebKit Commit Bot
Comment 8 2019-02-12 16:23:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-02-12 16:24:28 PST
<rdar://problem/48020260>
Darin Adler
Comment 10 2019-02-12 19:02:29 PST
Comment on attachment 361855 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review One small nit > Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35 > unsigned long size; This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned". > Source/WebCore/platform/graphics/gpu/GPUBufferUsage.h:34 > +using GPUBufferUsageFlags = unsigned long; This should be "unsigned", not "unsigned long".
Justin Fan
Comment 11 2019-02-13 15:38:28 PST
Comment on attachment 361855 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review >> Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35 >> unsigned long size; > > This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned". I did not know that, thanks. It looks like I have a lot of instances to fix for this across the Web GPU code base, then. I've planned out a week to do all sorts of clean-up for Web GPU so I'll add this to that to-do list. https://bugs.webkit.org/show_bug.cgi?id=194618
Note You need to log in before you can comment on or make changes to this bug.