Bug 194545

Summary: Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, beidson, cdumez, commit-queue, ggaren, koivisto, lforschler, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194480
https://bugs.webkit.org/show_bug.cgi?id=194481
Attachments:
Description Flags
Patch none

Description Aakash Jain 2019-02-12 11:02:55 PST
TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack seems flaky. In https://ews-build.webkit-uat.org/#/builders/20/builds/889, the test passed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it failed.
Comment 1 Aakash Jain 2019-02-27 05:55:11 PST
Can we prioritize this?
I am working on EWS for API tests, and this flaky failure is creating problem.
Comment 2 Chris Dumez 2019-02-27 10:52:40 PST
TestWebKitAPI.ProcessSwap.SuspendedPageLimit
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/worker/iOS-11-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2720
        Expected equality of these values:
          [processPool _webProcessCountIgnoringPrewarmed]
            Which is: 4
          (1U + maximumSuspendedPageCount)
            Which is: 3
Comment 3 Chris Dumez 2019-02-27 10:54:03 PST
It is actually:
 TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/worker/iOS-11-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3484
        Expected equality of these values:
          3
          numberOfDecidePolicyCalls
            Which is: 4
Comment 4 Chris Dumez 2019-02-27 15:55:03 PST
(In reply to Chris Dumez from comment #3)
> It is actually:
>  TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
>         Received data during response processing, queuing it.
>         Received data during response processing, queuing it.
>         
>        
> /Volumes/Data/worker/iOS-11-Simulator-Build-EWS/build/Tools/TestWebKitAPI/
> Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3484
>         Expected equality of these values:
>           3
>           numberOfDecidePolicyCalls
>             Which is: 4

Not sure how we can end up with an extra policy decision here...
Comment 5 Chris Dumez 2019-02-27 15:58:49 PST
(In reply to Chris Dumez from comment #4)
> (In reply to Chris Dumez from comment #3)
> > It is actually:
> >  TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
> >         Received data during response processing, queuing it.
> >         Received data during response processing, queuing it.
> >         
> >        
> > /Volumes/Data/worker/iOS-11-Simulator-Build-EWS/build/Tools/TestWebKitAPI/
> > Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3484
> >         Expected equality of these values:
> >           3
> >           numberOfDecidePolicyCalls
> >             Which is: 4
> 
> Not sure how we can end up with an extra policy decision here...

Oh, I have an idea, I'll confirm.
Comment 6 Chris Dumez 2019-02-27 16:13:41 PST
Created attachment 363151 [details]
Patch
Comment 7 WebKit Commit Bot 2019-02-27 16:43:43 PST
Comment on attachment 363151 [details]
Patch

Clearing flags on attachment: 363151

Committed r242179: <https://trac.webkit.org/changeset/242179>
Comment 8 WebKit Commit Bot 2019-02-27 16:43:45 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-27 16:48:26 PST
<rdar://problem/48456644>