Bug 194542

Summary: [JSC] Add JSC shell support for systems that don't provide a working directory
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, chris.reid, darin, don.olmstead, ews-watchlist, Hironori.Fujii, keith_miller, mark.lam, msaboff, ross.kirsling, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add --working-directory and related code
none
Add --working-directory and related code, move to file-scope NeverDestroyed
ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future
none
Add --working-directory and related code, move to file-scope NeverDestroyed none

Description Stephan Szabo 2019-02-12 08:49:13 PST
Add support to the JSC shell for systems that don't provide a working directory to user applications (e.g. PlayStation).

* Add in a --working-directory option to set the base working directory for such systems.
* When a directory has been set with the above, convert paths into absolute paths for opening.
  * fetchModuleFromLocalFileSystem says that it expects only absolute paths already, so no changes were made there.
* For PlayStation, do not try to call to getcwd.
Comment 1 Stephan Szabo 2019-02-12 08:54:30 PST
Created attachment 361799 [details]
Add --working-directory and related code
Comment 2 Stephan Szabo 2019-02-12 09:42:18 PST
Created attachment 361803 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Trying a NeverDestroyed static in file-scope to avoid -Wexit-time-destructors failures.
Comment 3 EWS Watchlist 2019-02-12 11:32:26 PST
Comment on attachment 361803 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Attachment 361803 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11123765

New failing tests:
js/dom/custom-constructors.html
Comment 4 EWS Watchlist 2019-02-12 11:32:38 PST
Created attachment 361815 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 5 Stephan Szabo 2019-02-12 11:50:11 PST
Created attachment 361817 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed
Comment 6 Mark Lam 2019-03-22 10:06:19 PDT
Comment on attachment 361817 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Taking out of review since the bug has been declared invalid.