Bug 194537

Summary: [GStreamer] Simplify GObject class name check
Product: WebKit Reporter: Bastien Nocera <bugzilla>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Trivial CC: bugs-noreply, commit-queue, mcatanzaro, pnormand
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Bastien Nocera
Reported 2019-02-12 06:42:24 PST
This line: https://sources.debian.org/src/webkit2gtk/2.23.3-1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp/#L1754 reads: if (g_strcmp0(G_OBJECT_CLASS_NAME(G_OBJECT_GET_CLASS(G_OBJECT(element))), "GstDownloadBuffer")) It could be simplified to: if (g_strcmp0(G_OBJECT_TYPE_NAME(element)), "GstDownloadBuffer"))
Attachments
Patch (1.71 KB, patch)
2019-02-15 08:48 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-02-15 08:48:19 PST
Created attachment 362117 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-15 09:26:22 PST
Comment on attachment 362117 [details] Patch Clearing flags on attachment: 362117 Committed r241590: <https://trac.webkit.org/changeset/241590>
WebKit Commit Bot
Comment 3 2019-02-15 09:26:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-02-15 15:30:45 PST
<rdar://problem/48126892>
Note You need to log in before you can comment on or make changes to this bug.